feat(repo): apply GC OSS Repo Template by bryanpaget · Pull Request #55 · StatCan/namespace-cleaner

bryanpaget · 2025-06-17T18:22:24Z

Context:

The namespace-cleaner has its own repo but none of the safeguards or settings of the repo have been configured to spec.

Todo:

Configure the repo with appropriate settings.
Refer to: https://github.com/gccloudone/oss-templates?tab=readme-ov-file

Expected Outcome:

Repo has settings to protect main branch and other standard safety settings.
Repo follows GC OSS template.

wg102

Is it normal the System overview section in the readme is eng only?

JustinZhang17 · 2025-06-25T18:22:23Z

@bryanpaget I noticed this pr changes the distribution license of the project to MIT, I believe the current license in your project is a GNU GPL (https://github.com/StatCan/namespace-cleaner/blob/main/LICENSE.txt), are you changing it?

GNU GPL: https://choosealicense.com/licenses/gpl-3.0/

Souheil-Yazji

LGTM!

Copilot

Pull Request Overview

This PR applies the GC OSS repository template by adding standard governance files and enhancing documentation with bilingual support.

Add SECURITY.md with vulnerability reporting guidelines in English and French.
Expand README.md to include detailed project overview, key features, CI/CD integration, configuration, and monitoring – all presented bilingually.
Introduce CONTRIBUTING.md and CODE_OF_CONDUCT.md following the GC template, both with English and French sections.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File	Description
SECURITY.md	Add security reporting instructions in English and French.
README.md	Update project README with bilingual sections and template layout.
CONTRIBUTING.md	Add contribution guidelines in English and French.
CODE_OF_CONDUCT.md	Add code of conduct in English and French.

Comments suppressed due to low confidence (2)

README.md:93

[nitpick] To keep the README fully bilingual, add a French equivalent heading (e.g., ‘## Vue d’ensemble du système’) before or after this line.

## System Overview

README.md:209

[nitpick] Consider adding a French translation for this section heading and inline comments to match the bilingual style used elsewhere.

## Configuration

Copilot · 2025-07-02T19:49:43Z

+
+## Sécurité
+
+**Ne publiez aucun problème de sécurité sur le dépôt publique!** Les vulnérabilités de sécurité doivent être signalées par courriel à `statcan.cybersecurity-cybersecurite.statcan@statcan.gc.ca`


In French, ‘dépôt’ is masculine, so the adjective should be ‘public’ rather than ‘publique’.

Suggested change

**Ne publiez aucun problème de sécurité sur le dépôt publique!** Les vulnérabilités de sécurité doivent être signalées par courriel à `statcan.cybersecurity-cybersecurite.statcan@statcan.gc.ca`

**Ne publiez aucun problème de sécurité sur le dépôt public!** Les vulnérabilités de sécurité doivent être signalées par courriel à `statcan.cybersecurity-cybersecurite.statcan@statcan.gc.ca`

Copilot · 2025-07-02T19:49:44Z

+
+### Sécurité
+
+**Ne publiez aucun problème de sécurité sur le dépôt publique!** Voir [SECURITY.md](SECURITY.md)


Apply the same correction here: use ‘dépôt public’ instead of ‘dépôt publique’.

Suggested change

**Ne publiez aucun problème de sécurité sur le dépôt publique!** Voir [SECURITY.md](SECURITY.md)

**Ne publiez aucun problème de sécurité sur le dépôt public!** Voir [SECURITY.md](SECURITY.md)

JustinZhang17 · 2025-07-02T19:50:18Z

+
+#### License
+
+Unless otherwise noted, the source code of this project is covered under Crown Copyright, Government of Canada, and is distributed under the [GNU Affero General Public License](LICENSE).


I like this, no suggestion, just a happy comment :)

JustinZhang17 · 2025-07-02T19:52:57Z

+## Key Features
+
+* ✅ **Automated Lifecycle Management** – Label-based namespace retention system
+* 🔒 **Security First** – Azure Entra ID user verification with domain allowlist
+* 🧪 **Testing Friendly** – Mock and dry-run support
+* ☁️ **Safe Operations** – Prevent accidental deletion through preview-only mode


Shouldn't this section be above with the rest of the english section? Sorry for all the comments lol

JustinZhang17 · 2025-07-02T19:54:11Z

+## CI/CD Integration / Intégration CI/CD
+
+Our GitHub Actions pipeline includes:
+Notre pipeline GitHub Actions comprend :
+
+* ✅ Unit testing and dry-run validation
+  ✅ Tests unitaires et validation en mode simulation
+* 🔒 Trivy-based container image vulnerability scanning
+  🔒 Analyse de vulnérabilités des images avec Trivy
+* 📦 Docker builds on push
+  📦 Construction des images Docker lors des *push*
+* 📈 Live test coverage badge generation
+  📈 Génération d'un badge de couverture de test en temps réel


Shouldn't the english and french be separated?

bryanpaget added 2 commits June 17, 2025 14:20

feat(repo): apply GC OSS Repo Template

11d0ee0

feat(repo): apply GC OSS Repo Template

ddfae35

This was linked to issues Jun 17, 2025

Document License in Readme #33

Closed

Comply with GC OSS Repo Template #34

Closed

bryanpaget requested a review from Souheil-Yazji June 18, 2025 13:06

bryanpaget self-assigned this Jun 18, 2025

bryanpaget added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 18, 2025

bryanpaget added this to the First Stable Release: 1.0 milestone Jun 18, 2025

bryanpaget marked this pull request as ready for review June 18, 2025 13:07

wg102 requested changes Jun 20, 2025

View reviewed changes

Comment thread README.md Outdated

Comment thread README.md Outdated

Comment thread README.md Outdated

Comment thread README.md Outdated

feat(i18n): update French translation

835aa47

wg102 reviewed Jun 24, 2025

View reviewed changes

JustinZhang17 mentioned this pull request Jun 23, 2025

docs: updating README and GH wiki with latest contribution practices/guide StatCan/volume-cleaner#43

Closed

5 tasks

Update SECURITY.md

891d769

JustinZhang17 suggested changes Jun 25, 2025

View reviewed changes

Comment thread LICENSE.md Outdated

Comment thread SECURITY.md Outdated

Comment thread SECURITY.md Outdated

Comment thread CODE_OF_CONDUCT.md Outdated

Comment thread CODE_OF_CONDUCT.md Outdated

bryanpaget added 9 commits June 25, 2025 15:13

Update README.md

a286eb6

Update LICENSE.md

b7f7a94

Update LICENSE.md

bda0331

Update README.md

c5d2bfe

Update README.md

b3c34e2

Update README.md

b6c0168

Update and rename LICENSE.md to LICENSE

ab7d961

Update README.md

1f893ac

feat(repo): apply GC OSS Repo Template

06b3d09

anrayliu previously approved these changes Jun 30, 2025

View reviewed changes

bryanpaget removed the request for review from Souheil-Yazji July 2, 2025 17:37

Souheil-Yazji previously approved these changes Jul 2, 2025

View reviewed changes

Comment thread README.md Outdated

feat(README.md): update language (delete vs remove)

31c0f1f

bryanpaget dismissed stale reviews from Souheil-Yazji and anrayliu via 31c0f1f July 2, 2025 17:50

bryanpaget requested review from JustinZhang17 and wg102 July 2, 2025 17:52

JustinZhang17 requested a review from Copilot July 2, 2025 19:48

Copilot AI reviewed Jul 2, 2025

View reviewed changes

JustinZhang17 reviewed Jul 2, 2025

View reviewed changes

JustinZhang17 suggested changes Jul 2, 2025

View reviewed changes

fix(readme): separate fr/en

a07c94d

Souheil-Yazji approved these changes Apr 14, 2026

View reviewed changes

Souheil-Yazji merged commit 2732a65 into main Apr 14, 2026
1 check failed

Souheil-Yazji deleted the bryan/update-repo-to-spec branch April 14, 2026 16:55


		## Sécurité

		Ne publiez aucun problème de sécurité sur le dépôt publique! Les vulnérabilités de sécurité doivent être signalées par courriel à `statcan.cybersecurity-cybersecurite.statcan@statcan.gc.ca`


		### Sécurité

		Ne publiez aucun problème de sécurité sur le dépôt publique! Voir [SECURITY.md](SECURITY.md) No newline at end of file


		#### License

		Unless otherwise noted, the source code of this project is covered under Crown Copyright, Government of Canada, and is distributed under the [GNU Affero General Public License](LICENSE).

Conversation

bryanpaget commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context:

Todo:

Expected Outcome:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wg102 left a comment

Choose a reason for hiding this comment

Uh oh!

JustinZhang17 commented Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Souheil-Yazji left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

JustinZhang17 Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

JustinZhang17 Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

JustinZhang17 Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bryanpaget commented Jun 17, 2025 •

edited

Loading